Skip to content

fix(pre-commit): normalize SPDX handling#23228

Open
bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:normalize-spdx-pre-commit
Open

fix(pre-commit): normalize SPDX handling#23228
bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:normalize-spdx-pre-commit

Conversation

@bdice

@bdice bdice commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

Contributes to rapidsai/build-planning#303.

Standardizes clang-format's SPDX protection and ensures the repository uses rapidsai/pre-commit-hooks v1.6.0. It also restores malformed SPDX headers where present.

Validated with pre-commit run --all-files.

Signed-off-by: Bradley Dice <bdice@bradleydice.com>
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Jul 10, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 10, 2026
@bdice bdice marked this pull request as ready for review July 11, 2026 00:58
@bdice bdice requested review from a team as code owners July 11, 2026 00:58
@bdice bdice requested a review from KyleFromNVIDIA July 11, 2026 00:58
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a67d3468-8eb1-444e-b037-2f99faeebc2b

📥 Commits

Reviewing files that changed from the base of the PR and between 151de69 and 4aa4417.

📒 Files selected for processing (42)
  • .pre-commit-config.yaml
  • cpp/libcudf_streaming/benchmarks/bench_pack.cpp
  • cpp/libcudf_streaming/benchmarks/bench_partition.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/data_generator.hpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/bench_read.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/concatenate.hpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/groupby.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/groupby.hpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/join.hpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/parquet_writer.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/parquet_writer.hpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/q09.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/sort.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/sort.hpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/utils.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/utils.hpp
  • cpp/libcudf_streaming/benchmarks/utils/comm.hpp
  • cpp/libcudf_streaming/benchmarks/utils/misc.hpp
  • cpp/libcudf_streaming/benchmarks/utils/random_data.cu
  • cpp/libcudf_streaming/benchmarks/utils/random_data.hpp
  • cpp/libcudf_streaming/examples/example_shuffle.cpp
  • cpp/libcudf_streaming/include/cudf_streaming/bloom_filter.hpp
  • cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp
  • cpp/libcudf_streaming/include/cudf_streaming/parquet.hpp
  • cpp/libcudf_streaming/include/cudf_streaming/partition.hpp
  • cpp/libcudf_streaming/include/cudf_streaming/partition_utils.hpp
  • cpp/libcudf_streaming/include/cudf_streaming/table_chunk.hpp
  • cpp/libcudf_streaming/include/cudf_streaming/utils.hpp
  • cpp/libcudf_streaming/src/detail/device_bloom_filter.cu
  • cpp/libcudf_streaming/src/partition_utils.cpp
  • cpp/libcudf_streaming/src/table_chunk.cpp
  • cpp/libcudf_streaming/src/utils.cpp
  • cpp/libcudf_streaming/tests/main/mpi.cpp
  • cpp/libcudf_streaming/tests/main/ucxx.cpp
  • cpp/libcudf_streaming/tests/streaming/base_streaming_fixture.hpp
  • cpp/libcudf_streaming/tests/streaming/test_cudf_utils.cpp
  • cpp/libcudf_streaming/tests/streaming/test_leaf_actor.cpp
  • cpp/libcudf_streaming/tests/streaming/test_partition.cpp
  • cpp/libcudf_streaming/tests/streaming/test_shuffler.cpp
  • cpp/libcudf_streaming/tests/streaming/test_table_chunk.cpp
  • cpp/libcudf_streaming/tests/test_partition.cpp
  • cpp/libcudf_streaming/tests/utils.hpp

📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Standardized license and copyright header metadata across streaming benchmarks, examples, library code, and tests.
    • Clarified Apache-2.0 SPDX identifiers and normalized copyright text formatting.
  • Chores

    • Updated pre-commit hooks to a newer revision.
    • No user-facing functionality, APIs, or runtime behavior changed.

Walkthrough

The change updates a pre-commit hook revision and standardizes SPDX license and copyright header metadata across libcudf_streaming benchmarks, library files, examples, and tests.

Changes

SPDX metadata updates

Layer / File(s) Summary
Pre-commit hook revision
.pre-commit-config.yaml
Updates the RAPIDS pre-commit hooks revision from v1.5.1 to v1.6.0.
Benchmark and library SPDX headers
cpp/libcudf_streaming/benchmarks/*, cpp/libcudf_streaming/examples/*, cpp/libcudf_streaming/include/*, cpp/libcudf_streaming/src/*
Standardizes Apache-2.0 SPDX identifiers and reformats copyright header text without changing code or declarations.
Test SPDX headers
cpp/libcudf_streaming/tests/*
Standardizes SPDX identifiers and copyright header formatting across test files without changing test logic.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: SPDX handling updates in pre-commit and headers.
Description check ✅ Passed The description is clearly related to the changeset and matches the SPDX/pre-commit updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant