Skip to content

Update flexmark from 0.42.14 to 0.64.8, minSdk to 21#2407

Open
guanglinn wants to merge 32 commits into
gsantner:masterfrom
guanglinn:libraries_update
Open

Update flexmark from 0.42.14 to 0.64.8, minSdk to 21#2407
guanglinn wants to merge 32 commits into
gsantner:masterfrom
guanglinn:libraries_update

Conversation

@guanglinn

@guanglinn guanglinn commented Sep 4, 2024

Copy link
Copy Markdown
Contributor
  1. Update flexmark from 0.42.14 to 0.64.8;
  2. Update some dependency libraries;
  3. Update minSdk from 18 to 21.

@guanglinn

guanglinn commented Sep 4, 2024

Copy link
Copy Markdown
Contributor Author

Since version 0.42.14, flexmark-java has got a large number of improvements and bug fixes, so it is worth upgrading it.

Marder works well and no issues occurred yet after updating flexmark and other libraries.

browser 1.8.0 requires minSdkVersion cannot be smaller than version 19.
appcompat 1.7.0 requires minSdkVersion cannot be smaller than version 21.

Even if we choose API 21 (Android 5.0, in 2014) as minimum SDK, Markor can still run on approximately 99% of devices, so we don't need to worry too much.

2024-08-04-min-sdk-version-21

@gsantner

Copy link
Copy Markdown
Owner

For sure there are improvements at every release. Though is there something specific that gave you reason to get a newer version?

@guanglinn guanglinn marked this pull request as ready for review November 16, 2024 07:43
@guanglinn guanglinn closed this Apr 12, 2025
@gsantner gsantner reopened this Apr 14, 2025
@gsantner gsantner marked this pull request as draft April 14, 2025 08:58
@JSchmerling

JSchmerling commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

From what I've seen so far, the benefits of upgrading are improved performance (https://github.com/vsch/flexmark-java/wiki/Version-0.60.0-Changes) and better handling of MarkDown extensions (flexmark-all).

@guanglinn guanglinn marked this pull request as ready for review October 23, 2025 02:55
@gsantner gsantner added this to the Markor v2.16 milestone Jan 31, 2026
@gsantner

Copy link
Copy Markdown
Owner

I think the time is now right to update to a newer minimum SDK version. Let's merge this after the next update.

@guanglinn guanglinn mentioned this pull request Feb 7, 2026
4 tasks
@gsantner gsantner force-pushed the master branch 3 times, most recently from d3c16f5 to c3bd617 Compare March 6, 2026 18:41
@guanglinn

guanglinn commented Apr 12, 2026

Copy link
Copy Markdown
Contributor Author

I will implement rich text pasting after this PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants