Create whitelist of non-OSI approved licenses#282
Merged
Conversation
|
Maintaining OSI approval appears to me to be valuable. It gives each license proposal an extra layer of validation (and, as you have noted earlier, trims the long tail considerably). For licenses this project is interested in keeping track of that the OSI has not approved should be added to a whitelist whose membership is excluded from the OSI validation. |
This reverts commit 4b536ab.
Merged
Contributor
Author
|
This pull request as written just simplifies an existing test (moving two conditionals to a constant) and will get tests green on master. Merging, but glad to continue the discussion over in #281. |
benbalter
added a commit
that referenced
this pull request
Aug 22, 2015
Remove OSI approval requirement from tests
|
Tiny nit: would you mind renaming this PR to describe the changes that were merged? |
benbalter
changed the title
Contributor
Author
|
@parkr really good call. Done. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281.